BoundaryInfo method additions #4268
Open
+584
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support using the same id for different boundary sets of different types, but we don't support it *well* yet, which is one reason MOOSE (and other downstream codes?) don't really support it at all. Let's start fixing that.
We support using the same id for different boundary sets of different types, but we don't support it *well* yet, which is one reason MOOSE (and other downstream codes?) don't really support it at all. Let's continue fixing that.
Fully regenerating all our caches is overkill in some situations
This covers node+edge+side ids, at least.
|
Job Coverage, step Generate coverage on a01b148 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
We should have done this while we were at it with libMesh#4247, but better late than never.
jwpeterson
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support using the same id for different boundary sets of different types, but we don't support it well yet, which is one reason MOOSE (and other downstream codes?) don't really support it at all. Let's start fixing that. These methods let us do id removal and renumbering for one boundary type at a time, not just for all types at once.