Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remodel electrochemistry module interface API to adhere to PEP-8 conventions #218

Merged
merged 11 commits into from
Jan 14, 2024
Merged

MAINT: Remodel electrochemistry module interface API to adhere to PEP-8 conventions #218

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4889b56
TST: fix skippable test forfenics integration
jotelha Jan 13, 2024
3fcaad6
MAINT: Camel case to lower case for electrochemistry methods, and oth…
jotelha Jan 13, 2024
cbd9a65
CI: run tests on pull requests
jotelha Jan 13, 2024
4539c2a
CI: remove CI workflow for running electrochemistry examples as examp…
jotelha Jan 13, 2024
0326294
CI: provide fenics in tests work flow to avoid skipping fenics-depend…
jotelha Jan 13, 2024
2c64685
TST: print stderr of CLI commands to understand why and where pipelin…
jotelha Jan 14, 2024
2c39664
TST: inspect both stdout and stderr of CLI test thorougly
jotelha Jan 14, 2024
aca11d8
MAINT: a little bit of trial and error on what will make fenics logs …
jotelha Jan 14, 2024
2a5ecac
MAINT: more trial and error on what will make fenics logs silent
jotelha Jan 14, 2024
3036e23
MAINT: desperate trial and error on what will make fenics logs silent
jotelha Jan 14, 2024
5aec6e3
MAINT: endless trial and error on what will make fenics logs silent
jotelha Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MAINT: a little bit of trial and error on what will make fenics logs … 
…silent in CI
  • Loading branch information
@jotelha
jotelha committed Jan 14, 2024
commit aca11d8c207d992f306b3d78cee0d80c4b7ac0fa
7 changes: 6 additions & 1 deletion matscipy/cli/electrochemistry/poisson_nernst_planck_solver_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,12 @@ class ArgumentDefaultsAndRawDescriptionHelpFormatter(
# fenics writes some log messages to stdout. If we pipe the output,
# we don't want that, hence here we have to suppress fenics logging
# if no output file has been specified
dolfin.cpp.log.set_log_active(False)
try:
dolfin.cpp.log.set_log_active(False)
logging.getLogger('UFL').setLevel(logging.WARNING)
logging.getLogger('FFC').setLevel(logging.WARNING)
except: # if fenics not available, ignore any error here
pass

pnp.solve()

Expand Down
Loading