-
Notifications
You must be signed in to change notification settings - Fork 5
Add OpenSearch backend #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ElliottKasoar
wants to merge
112
commits into
libAtoms:master
Choose a base branch
from
ElliottKasoar:add-opensearch-updated
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add OpenSearch backend #123
ElliottKasoar
wants to merge
112
commits into
libAtoms:master
from
ElliottKasoar:add-opensearch-updated
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made schema analysis optional for query building, primarily since get_mapping is not supported by openmock, although it may be useful in itself.
Add option for colons when parsing key-value pairs for extra information, to allow formatting closer to Lucene queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated version of #107.
Now that we've added poetry (aside: we should consider updating to poetry v2 now that it has released, or perhaps moving on to uv, as I have for my other projects), and added proper CI, as discussed with @stenczelt, this is a rebased and updated implementation of OpenSearch.
There are a few internal review comments (ElliottKasoar#31) remaining, but I think they largely affect non-OpenSearch specific parts of the code, so I think we should address them separately.