Make option parsing more conformant to libpq behaviour. #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {"user=foo blah", values{"user": "foo"}, true}, | ||
| {"user=foo blah ", values{"user": "foo"}, true}, | ||
| {"user=foo blah= ", values{"user": "foo"}, true}, | ||
|
|
||
| // No '=' after the key |
There was a problem hiding this comment.
This comment applies to the unchanged line below, I believe.
There was a problem hiding this comment.
It applies to all four tests here.
There was a problem hiding this comment.
Oh I see, I guess that's true. The URL format threw me off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I misread some of the pointer dancing going on in conninfo_parse, this commit fixes that.
Fixes #162