Initial type annotations #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-m
commented
Oct 27, 2019
| """ | ||
| The index of the prime | ||
| """ | ||
| if not self or self[-1] < prime: | ||
| super().extend(primes_up_to(prime, self)[len(self):]) | ||
| return super().index(prime) | ||
| return super().index(prime, start, stop or len(self)) |
There was a problem hiding this comment.
It's strange that we have to do stop or len(self), but without it we get
primes.py:61: error: Argument 3 to "index" of "list" has incompatible type "Optional[int]"; expected "int"
liam-m
commented
Oct 27, 2019
| """ | ||
| List subclass that supports slicing and membership checking, automatically | ||
| generating new primes when needed | ||
| """ | ||
|
|
||
| def __contains__(self, item): | ||
| def __contains__(self, item: Any) -> bool: |
There was a problem hiding this comment.
Ideally all of these parameters would be int rather than Any
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.