Update SwiftClipper to use Doubles and fix some issues#7
Open
Cyberax wants to merge 1 commit intolhuanyu:masterfrom
Open
Update SwiftClipper to use Doubles and fix some issues#7Cyberax wants to merge 1 commit intolhuanyu:masterfrom
Cyberax wants to merge 1 commit intolhuanyu:masterfrom
Conversation
This change updates SwiftClipper to use Double precision for all the calculations. This can break on 32-bit builds because CGPoint uses single-precision floats on 32-bit targets. There also were several bugfixes: 1. Path orientation was always `positive` because the `area` method used `abs()`. I replaced it with a `signedArea` method. 2. `parseFirstLeft` method can return `nil`s, so I removed unwrapping from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates SwiftClipper to use Double precision for all the calculations. This can break on 32-bit builds because CGPoint uses single-precision floats on 32-bit targets.
There also were several bugfixes:
positivebecause theareamethod usedabs(). I replaced it with asignedAreamethod.parseFirstLeftmethod can returnnils, so I removed unwrapping from it.I also fixed the tests to utilize the full un-rounded precision.