Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC 7 has some issues about explicit instantiation #311

Merged
merged 2 commits into from
Feb 25, 2024
Merged

GCC 7 has some issues about explicit instantiation #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a677a8d
Revert "value: Reorder explicit instantiations"
lhmouse Feb 25, 2024
0271fac
rocket/*: Try evading explicit instantiation issues in GCC 7
lhmouse Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asteria/value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
#include "llds/variable_hashmap.hpp"
#include "../rocket/linear_buffer.hpp"
#include "../rocket/tinyfmt_file.hpp"
template class ::rocket::variant<ASTERIA_TYPES_AIXE9XIG_(::asteria::V)>;
template class ::rocket::optional<::asteria::Value>;
template class ::rocket::cow_vector<::asteria::Value>;
template class ::rocket::cow_hashmap<::asteria::phsh_string,
::asteria::Value, ::asteria::phsh_string::hash>;
template class ::rocket::variant<ASTERIA_TYPES_AIXE9XIG_(::asteria::V)>;
namespace asteria {
namespace {

Expand Down
2 changes: 1 addition & 1 deletion asteria/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,9 @@ operator<<(tinyfmt& fmt, const Value& value)
{ return value.print_to(fmt); }

} // namespace asteria
extern template class ::rocket::variant<ASTERIA_TYPES_AIXE9XIG_(::asteria::V)>;
extern template class ::rocket::optional<::asteria::Value>;
extern template class ::rocket::cow_vector<::asteria::Value>;
extern template class ::rocket::cow_hashmap<::asteria::phsh_string,
::asteria::Value, ::asteria::phsh_string::hash>;
extern template class ::rocket::variant<ASTERIA_TYPES_AIXE9XIG_(::asteria::V)>;
#endif
1 change: 1 addition & 0 deletions rocket/cow_hashmap.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ class cow_hashmap

public:
// 26.5.4.2, construct/copy/destroy
ROCKET_ALWAYS_INLINE // https://gcc.gnu.org/PR109464
constexpr cow_hashmap()
noexcept(conjunction<is_nothrow_constructible<allocator_type>,
is_nothrow_constructible<hasher>,
Expand Down
1 change: 1 addition & 0 deletions rocket/cow_vector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ class cow_vector

public:
// 26.3.11.2, construct/copy/destroy
ROCKET_ALWAYS_INLINE // https://gcc.gnu.org/PR109464
constexpr cow_vector() noexcept(is_nothrow_constructible<allocator_type>::value)
:
m_sth()
Expand Down
1 change: 1 addition & 0 deletions rocket/refcnt_ptr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ class refcnt_ptr
details_refcnt_ptr::stored_pointer<element_type> m_sth;

public:
ROCKET_ALWAYS_INLINE // https://gcc.gnu.org/PR109464
constexpr refcnt_ptr(nullptr_t = nullptr) noexcept
:
m_sth()
Expand Down
3 changes: 2 additions & 1 deletion rocket/static_vector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ class static_vector

public:
// 26.3.11.2, construct/copy/destroy
static_vector() noexcept(is_nothrow_constructible<allocator_type>::value)
ROCKET_ALWAYS_INLINE // https://gcc.gnu.org/PR109464
constexpr static_vector() noexcept(is_nothrow_constructible<allocator_type>::value)
:
m_sth()
{ }
Expand Down
1 change: 1 addition & 0 deletions rocket/unique_ptr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class unique_ptr

public:
// 23.11.1.2.1, constructors
ROCKET_ALWAYS_INLINE // https://gcc.gnu.org/PR109464
constexpr unique_ptr(nullptr_t = nullptr) noexcept(is_nothrow_constructible<deleter_type>::value)
:
m_sth()
Expand Down
Loading