Skip to content

Commit

Permalink
highmem: Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, a…
Browse files Browse the repository at this point in the history
…nd KM_NMI_PTE

Previously calling debug_kmap_atomic() with these types would
cause spurious warnings.

(triggered by SysProf using perf events)

Signed-off-by: Soeren Sandmann Pedersen <sandmann@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: a.p.zijlstra@chello.nl
Cc: <stable@kernel.org> # .31.x
LKML-Reference: <ye8vdhz8krw.fsf@camel23.daimi.au.dk>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
sorensp authored and Ingo Molnar committed Nov 10, 2009
1 parent 5ebd4c2 commit d451564
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions mm/highmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -432,10 +432,15 @@ void debug_kmap_atomic(enum km_type type)
return;

if (unlikely(in_interrupt())) {
if (in_irq()) {
if (in_nmi()) {
if (type != KM_NMI && type != KM_NMI_PTE) {
WARN_ON(1);
warn_count--;
}
} else if (in_irq()) {
if (type != KM_IRQ0 && type != KM_IRQ1 &&
type != KM_BIO_SRC_IRQ && type != KM_BIO_DST_IRQ &&
type != KM_BOUNCE_READ) {
type != KM_BOUNCE_READ && type != KM_IRQ_PTE) {
WARN_ON(1);
warn_count--;
}
Expand All @@ -452,7 +457,9 @@ void debug_kmap_atomic(enum km_type type)
}

if (type == KM_IRQ0 || type == KM_IRQ1 || type == KM_BOUNCE_READ ||
type == KM_BIO_SRC_IRQ || type == KM_BIO_DST_IRQ) {
type == KM_BIO_SRC_IRQ || type == KM_BIO_DST_IRQ ||
type == KM_IRQ_PTE || type == KM_NMI ||
type == KM_NMI_PTE ) {
if (!irqs_disabled()) {
WARN_ON(1);
warn_count--;
Expand Down

0 comments on commit d451564

Please sign in to comment.