Skip to content

Commit

Permalink
block: don't use bio_has_data() in the completion path
Browse files Browse the repository at this point in the history
We should just check for rq->bio, as that is really the information
we are looking for. Even if the bio attached doesn't carry data,
we still need to do IO post processing on it.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Jens Axboe committed Oct 9, 2008
1 parent ab780f1 commit 6054016
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,7 @@ static int blk_end_io(struct request *rq, int error, unsigned int nr_bytes,
struct request_queue *q = rq->q;
unsigned long flags = 0UL;

if (bio_has_data(rq->bio) || blk_discard_rq(rq)) {
if (rq->bio) {
if (__end_that_request_first(rq, error, nr_bytes))
return 1;

Expand Down Expand Up @@ -1875,8 +1875,7 @@ EXPORT_SYMBOL_GPL(blk_end_request);
**/
int __blk_end_request(struct request *rq, int error, unsigned int nr_bytes)
{
if ((bio_has_data(rq->bio) || blk_discard_rq(rq)) &&
__end_that_request_first(rq, error, nr_bytes))
if (rq->bio && __end_that_request_first(rq, error, nr_bytes))
return 1;

add_disk_randomness(rq->rq_disk);
Expand Down

0 comments on commit 6054016

Please sign in to comment.