Skip to content

Commit

Permalink
[JFFS2] Clean up jffs2_alloc_inode() and jffs2_i_init_once()
Browse files Browse the repository at this point in the history
Ditch a couple of pointless casts from void *, and use the normal
variable name 'f' for jffs2_inode_info pointers -- especially since
it actually shows up in lockdep reports.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
dwmw2 committed May 1, 2008
1 parent fb96c00 commit 4e571ab
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions fs/jffs2/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,12 @@ static struct kmem_cache *jffs2_inode_cachep;

static struct inode *jffs2_alloc_inode(struct super_block *sb)
{
struct jffs2_inode_info *ei;
ei = (struct jffs2_inode_info *)kmem_cache_alloc(jffs2_inode_cachep, GFP_KERNEL);
if (!ei)
struct jffs2_inode_info *f;

f = kmem_cache_alloc(jffs2_inode_cachep, GFP_KERNEL);
if (!f)
return NULL;
return &ei->vfs_inode;
return &f->vfs_inode;
}

static void jffs2_destroy_inode(struct inode *inode)
Expand All @@ -45,10 +46,10 @@ static void jffs2_destroy_inode(struct inode *inode)

static void jffs2_i_init_once(struct kmem_cache *cachep, void *foo)
{
struct jffs2_inode_info *ei = (struct jffs2_inode_info *) foo;
struct jffs2_inode_info *f = foo;

mutex_init(&ei->sem);
inode_init_once(&ei->vfs_inode);
mutex_init(&f->sem);
inode_init_once(&f->vfs_inode);
}

static int jffs2_sync_fs(struct super_block *sb, int wait)
Expand Down

0 comments on commit 4e571ab

Please sign in to comment.