Skip to content

Conversation

@ndaniel
Copy link

@ndaniel ndaniel commented Sep 20, 2014

added -B/-E to trimfq for keeping first/last INT bp"

added -B/-E to trimfq for keeping first/last INT bp"
fixing bugs and also "shortcircuting" the case when param == 0
fixing bugs
fixing description
Updated with -B/-E for trimfq examples
seqtk.c Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here mate! from rigth

fixed typo "rigth" to "right"
@ndaniel
Copy link
Author

ndaniel commented Sep 20, 2014

Thx! Fixed!

updated version string to 1.0-r68a-dirty
Added the possibility to use simultaneously in trimfq:
a) -e with -E, and 
b) -b with -B.
Added examples for use simultaneously use with trimfq of:
a) -e with -E, and 
b) -b with -B.
setting the minimum length
the minimum reads after the trimming is 1 instead of zero (no reads with length 0 are created)
fixes bugs and descriptions of "trimfq -l"
Adding example for "trimfq -l" usage with other trimming options.
trying to fix locally the bug where reads with no sequence are converted to FASTA format in TRIMFQ and also setting be default "trimfq -l" to 1 instead of 30.
fixing bug in trimfq
fixed bugs regarding trimfq
updated to the version string to: 1.0-r68e-dirty
@ndaniel
Copy link
Author

ndaniel commented Jun 13, 2015

These additions/patches are used heavily by FusionCatcher (which has a lot of users and also brings a lot of users to SeqTK tools) and therefore it would be great if they would be merged into the master branch!

See: ndaniel/fusioncatcher#4

@ndaniel ndaniel closed this Oct 22, 2015
@ndaniel ndaniel reopened this Oct 22, 2015
@lh3
Copy link
Owner

lh3 commented Apr 6, 2016

-B is now implemented via -L. I guess the need of -E is rare. I will come back to it when someone really wants this feature. Thanks a lot for the PR anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants