Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Status check should say how many approvals needed #3

Open
donny-dont opened this issue Jan 26, 2016 · 5 comments
Open

Status check should say how many approvals needed #3

donny-dont opened this issue Jan 26, 2016 · 5 comments
Labels
enhancement help wanted

Comments

@donny-dont
Copy link

It would be great to have something like the following to say how many approvals are required.

1 of 2 maintainers approved
@kcsasquatch
Copy link

👍

jonbodner pushed a commit to jonbodner/lgtm that referenced this issue Jun 17, 2016
Merge pull request lgtmco#3 from jonbodner/pr_register_status_check
0d57260 
Pr register status check
@marcinwyszynski
Copy link
Contributor

My team is complaining about that, too. I'll happily help.

@marcinwyszynski marcinwyszynski mentioned this issue Aug 29, 2016
Merged
@marcinwyszynski
Copy link
Contributor

marcinwyszynski commented Aug 31, 2016 •
edited
Loading

This is working now.

screen shot 2016-08-31 at 13 34 07

The only other thing I think is worth considering is sending this status also on PR open event, not just on comments.

@donny-dont
Copy link
Author

@marcinwyszynski great work! I think it would be great to have the status be there when its opened as well.

@marcinwyszynski
Copy link
Contributor

@donny-dont I'll look into it.

@marcinwyszynski marcinwyszynski mentioned this issue Aug 31, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marcinwyszynski @donny-dont @bradrydzewski @kcsasquatch