Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Github usernames are case-insensitive #19

Open
ljharb opened this issue May 10, 2016 · 3 comments
Open

Github usernames are case-insensitive #19

ljharb opened this issue May 10, 2016 · 3 comments

Comments

@ljharb
Copy link

ljharb commented May 10, 2016

enzymejs/enzyme#342 (comment) wasn't recognized because the capitalization on the username is different https://github.com/airbnb/enzyme/blob/master/MAINTAINERS#L4

Github usernames are (and should be) case-insensitive.

@ljharb
Copy link
Author

ljharb commented May 11, 2016

I'm not familiar with go, but

lgtm/web/hook.go

Lines 112 to 116 in 66ef421

if config.SelfApprovalOff && comment.Author == issue.Author {
continue
}
// the user must be a valid maintainer of the project
person, ok := maintainer.People[comment.Author]
implies to me that all usernames should be lowercased as soon as they're received from github, to avoid having to do it in a multitude of places?

Idrinth added a commit to IDotD/Userscript that referenced this issue Sep 14, 2016
@Idrinth
Copy link

Idrinth commented Sep 14, 2016

at the very least it should be made clear in the documentation, that this doesn't follow the usual case-insensitive approach.

@ljharb
Copy link
Author

ljharb commented Sep 14, 2016

At a minimum yes, but this is a pretty important inconsistency that should ideally be fixed :-/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants