build: Silence gcc new/delete warnings for texturesys (AcademySoftwar…

…eFoundation#3944)

Disable GCC warnings around mismatched new/delete for shared_texturesys
creation


Signed-off-by: Shootfast <markboo99@gmail.com>
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Co-authored-by: Larry Gritz <lg@larrygritz.com>

src/libtexture/texturesys.cpp

@@ -81,6 +81,12 @@ static const OIIO_SIMD4_ALIGN vbool4 channel_masks[5] = {
 TextureSystem*
 TextureSystem::create(bool shared, ImageCache* imagecache)
 {
+    // Because the shared_texturesys is never deleted (by design)
+    // we silence the otherwise useful compiler warning on newer GCC versions
+    OIIO_PRAGMA_WARNING_PUSH
+#if OIIO_GNUC_VERSION > 100000
+    OIIO_GCC_ONLY_PRAGMA(GCC diagnostic ignored "-Wmismatched-new-delete")
+#endif
     if (shared) {
         // They requested a shared texture system.  If a shared one already
         // exists, just return it, otherwise record the new texture system
@@ -106,6 +112,7 @@ TextureSystem::create(bool shared, ImageCache* imagecache)
 #if 0
     std::cerr << "creating new ImageCache " << (void *)ts << "\n";
 #endif
+    OIIO_PRAGMA_WARNING_POP
     return ts;
 }