fix: min retention days and max retention days required #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that both min_retention_days and max_retention_days are provided when vault locking is enabled, and maintain the condition that min_retention_days must be less than or equal to max_retention_days.
- Document fixes for vault retention days validation and backup selection conditions in CHANGELOG.md. - Update AWS provider version in README.md from 5.89.0 to 5.91.0.
lgallard
deleted the
fix/min_retention_days_and_max_retention_days_required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the validation and documentation of the AWS backup module. The most important changes include updating the validation logic for vault retention days, updating the AWS provider version, and documenting these changes in the changelog.
Validation improvements:
main.tf: Updated the precondition logic in theaws_backup_vaultresource to ensuremin_retention_daysandmax_retention_daysare provided when vault locking is enabled and to validate thatmin_retention_daysis less than or equal tomax_retention_days. It fixes Variables min_retention_days and max_retention_days required after 0.23.0 #95Documentation updates:
CHANGELOG.md: Added a new entry for version 0.23.3, documenting the fixes for vault retention days validation and conditions in backup selections.README.md: Updated the AWS provider version from 5.89.0 to 5.91.0.