Feat!: GitHub/Gerrit closed loop testing fixes #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 4, 2025 10:35
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
62da060 to
028cb53
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 4, 2025 11:29
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
2 times, most recently
from
e5411ba to
993f715
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 7, 2025 13:27
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
993f715 to
1d98999
Compare
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
1d98999 to
4c5c8e7
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 7, 2025 13:53
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
4c5c8e7 to
423e1cd
Compare
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
423e1cd to
63faf2b
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 8, 2025 09:00
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
63faf2b to
18ea5d6
Compare
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
18ea5d6 to
512f26a
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
December 17, 2025 18:17
View session
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
January 6, 2026 17:30
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
2 times, most recently
from
1337aba to
c0748ef
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
January 7, 2026 11:12
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
2 times, most recently
from
d312b4e to
68a110a
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
January 7, 2026 14:44
View session
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
3 times, most recently
from
431257a to
f68b34b
Compare
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
2 times, most recently
from
0d435df to
5e02298
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
January 12, 2026 12:02
View session
Contributor
Author
|
Needs: #100 |
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
5e02298 to
f1062f5
Compare
- Abandoned Gerrit changes are now closed automatically in GitHub - Closed/superceded GitHub pull requests are now closed in Gerrit Also: - Converted some INFO messages to DEBUG to reduce console/job output noise - Fixed max_workers calculation when no work to perform - Ensure full/complete exception error propagation - Test isolation improvements related to processing changes - Minor markdown formatting/linting updates in documentation - Various output message/console logging updates/improvements - Minor changes to typer/exception handling and exit status - Filter HTML and markdown when copying Github comments to Gerrit Flow/logic was optimised to: 1. Reconcile first: Determine `reuse_ids` before preparing commits 2. Single preparation: Prepare commits once with correct `reuse_ids` Breaking changes due to change in default behaviour: - ALLOW_DUPLICATES default set from false -> true - SIMILARITY_FILES default set from false -> true ALLOW_DUPLICATES was primarily used during testing, has little effect in production workflows. SIMILARITY_FILES affects how commits are matched during pull request updates and changes reconcilliation behaviour. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
ModeSevenIndustrialSolutions
force-pushed
the
sync-updates
branch
from
f1062f5 to
8a06f33
Compare
Copilot started reviewing on behalf of
ModeSevenIndustrialSolutions
January 12, 2026 12:33
View session
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tykeal
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat!: GitHub/Gerrit closed loop testing fixes
Also:
Flow/logic was optimised to:
reuse_idsbefore preparing commitsreuse_idsBreaking change due to change in default behaviour: