Fix: Improve logging after pull request evaluation #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds enhanced diagnostic logging and improves commit metadata trailer handling. Key changes introduce double-newline separation for injected GitHub metadata trailers to avoid malformed footer sections and expand SSH / push error logging for better troubleshooting.
- Added regression tests around metadata trailer separation (double newline requirement)
- Replaced single newline injections in core commit paths with double newline for proper footer separation
- Expanded verbose and unconditional logging for SSH setup and Gerrit push failure analysis (including conditional raw output)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_metadata_trailer_separation_bug.py | New regression tests validating correct separation and idempotency of metadata trailers. |
| src/github2gerrit/core.py | Adds extensive debug logging, switches trailer injection to double newlines, enhances error analysis, and revises push failure handling. |
| src/github2gerrit/cli.py | Improves surfaced error messaging and adds optional verbose traceback logging. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ModeSevenIndustrialSolutions
force-pushed
the
add-logging
branch
2 times, most recently
from
aea02a6 to
68a6a18
Compare
Debug logging output was not visible in verbose mode once the pull request details were displayed. Several problems related to the log handling needed to be fixed. Signed-off-by: ModeSevenIndustrialSolutions <mwatkins@linuxfoundation.org>
ModeSevenIndustrialSolutions
force-pushed
the
add-logging
branch
from
68a6a18 to
7c8d6a6
Compare
ModeSevenIndustrialSolutions
changed the title
ModeSevenIndustrialSolutions
added
bug
tykeal
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug logging output was not visible in verbose mode once the pull request details were displayed. Several problems related to the log handling needed to be fixed.