Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to view output from build #47

Merged
merged 1 commit into from
May 17, 2022
Merged

Add button to view output from build #47

merged 1 commit into from
May 17, 2022

Conversation

petervdonovan
Copy link
Contributor

This change makes it easier to find textual output from the language server. It should allow VS Code users to receive most of the same information that is available from the standalone compiler. The button looks like this:
Screenshot from 2022-05-16 16-52-46

The output looks like this:
Screenshot from 2022-05-16 16-54-00

The output includes ALL messages that have been generated by the language server via System.err and System.out. This may be confusing ("where do the logs start and end?"), but it makes the implementation simple because it means we do not have to worry about what does and does not belong in the output.

This branch in the main repo should be merged first.

Fixes #42.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a very useful feature.

@lhstrh lhstrh changed the title Add button to view output from build. Add button to view output from build May 17, 2022
@petervdonovan petervdonovan merged commit f9c4f2d into main May 17, 2022
@petervdonovan petervdonovan deleted the view-output branch May 17, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cmake errors need to show more details
2 participants