Make "Build and Run" action work irrespective of current working directory #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
reviewed
Apr 27, 2022
| @@ -98,8 +97,7 @@ export async function activate(context: ExtensionContext) { | |||
| name: runTerminalName, | |||
| cwd: command[0] | |||
| }); | |||
| else if (lastWorkingDirectory !== command[0]) terminal.sendText('cd ' + command[0]); | |||
| lastWorkingDirectory = command[0]; | |||
| terminal.sendText('cd ' + command[0]); | |||
There was a problem hiding this comment.
I haven't tried this yet, but if command[0] is not an absolute path, then wouldn't the cd fail in case the shell is not in the right directory to begin with?
There was a problem hiding this comment.
Wouldn't a more obvious fix be to remove the if statement on line 97, always creating a new terminal regardless of whether one exists already?
There was a problem hiding this comment.
command[0] is an absolute path. Only the command itself uses a possibly relative path.
The problem with creating a new terminal each time is that they can accumulate and cause clutter, as shown below:
There was a problem hiding this comment.
Gotcha. Yes, if command[0] is absolute, then this will work. Great! Thanks for the fix!
lhstrh
approved these changes
Apr 27, 2022
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the working directory before running any commands. Unfortunately there is no way to check if the user has changed to a different working directory, so this action will be performed unconditionally when the "Build and Run" action is triggered.
The request was to use absolute paths instead of relative paths. This does not do that because this method was easier to implement, and because it might be more robust if we have run commands that behave differently according to the current working directory. If we really want absolute paths, then that is no problem, but it would just take some more testing and changes in the
lingua-francamain repo.