Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency tests ran only if relevant files change #117

Merged
merged 1 commit into from
May 17, 2023

Conversation

petervdonovan
Copy link
Contributor

The dependency tests fail more often than not and pertain to code that has not been modified in a long time, so we should run them selectively.

@petervdonovan petervdonovan marked this pull request as ready for review May 17, 2023 22:29
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@lhstrh lhstrh merged commit 4bba8cd into main May 17, 2023
@petervdonovan petervdonovan deleted the disable-dependency-tests branch May 17, 2023 23:11
@lhstrh lhstrh changed the title Run dependency tests only if relevant files change Dependency tests ran only if relevant files change Aug 28, 2023
@lhstrh lhstrh added the testing label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants