-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagram bug fixed #116
Diagram bug fixed #116
Conversation
Looks like the fix introduced another problem... |
3dc1110
to
cc495a4
Compare
This reverts commit f85abfc. It was also necessary to update node in order to get `npx tsc --lib "dom" --outDir out/test --inlineSourceMap` to succeed without errors.
This is a response to very flaky PMPM installation tests on Windows (test-dependencies-missing-extended).
This is in response to persistently failing test-dependencies-missing-extended tests on Windows, in particular for PNPM.
382eca4
to
3ab9edc
Compare
I believe that this results from the caching improvements that were recently made specifically for Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this have to be changed? We use prepare-build-env
almost everywhere, so it should just work...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the nature of the changes in the known-good texts?
There is an error due to the CWD being
I updated the lingua-franca submodule, so the content of the tests changed. |
I see. It's a bit mysterious as to why this error cropped up all of a sudden, but the workaround is fine with me.
👍 |
Probably the Windows error was related to the caching improvements. It's the only recent change that I was aware of. |
This partially reverts commit f85abfc.
This fixes #113.
Thank you to @soerendomroes for helping us find the source of the problem.