-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Linguist #111
Conversation
It can help to use both our own rule and a C++ rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that most of the changes in the "known good" files come from tokenizing whitespace, which seems entirely harmless. I just pushed some slight changes to the way types are highlighted in C/C++ to make sure there were no significant regressions there. I think that we should merge this.
This PR is an updated version of #104 that incorporates the new syntax highlight tests (and slightly alters the known-good outputs). The purpose of the changes is to eliminate constructs that linguist does not allow (such as unbounded look-aheads) from our TextMate syntax description. After this is merged, we should be able to create PR for linguist.