-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for STM32 #302
Open
naichenzhao
wants to merge
46
commits into
main
Choose a base branch
from
stm32
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+257
−3
Open
Support for STM32 #302
Changes from 2 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
6de22f6
initial test for support for STM32
naichenzhao 256abcc
Point to lingua-franca stm32 branch
lhstrh 92fcfbe
fixed typo
naichenzhao dca5be8
please merge
naichenzhao 89986a9
hard coded STM32 support
naichenzhao 436b36b
we dont need STM_main anymore
naichenzhao bcbbf43
updated files to move stuff out of core cmake
naichenzhao 48be057
fixed printing
naichenzhao 31d62b2
changed naming
naichenzhao 73aea2e
updated sleep functions
naichenzhao 7899e6b
updated delay functions
naichenzhao d11f3ff
rebased in main
naichenzhao 58d2323
change
naichenzhao 5ae3be6
fixed typo
naichenzhao 4bb9231
bruh
naichenzhao 9527537
we dont need STM_main anymore
naichenzhao 8a97bcd
changes
naichenzhao c46fbcc
fixed printing
naichenzhao b3097a8
changed naming
naichenzhao f92307f
updated sleep functions
naichenzhao f2554dd
updated delay functions
naichenzhao 03124a5
merge
naichenzhao 6d2964c
Merge branch 'stm32' of github.com:lf-lang/reactor-c into stm32
naichenzhao 13ca0d8
Merge branch 'main' of github.com:lf-lang/reactor-c into stm32
naichenzhao cd0c9c1
quick commit
naichenzhao 6d8d4db
Suppress unused parameter error
edwardalee bb75db6
Suppress unused parameter error
edwardalee 6a66f47
deleted artifact from rebase
naichenzhao a285e52
works with newest version
naichenzhao 6ba0f42
did formatting
naichenzhao a22a4fd
Update low_level_platform/api/platform/lf_STM32f4_support.h
naichenzhao 42fc271
Update low_level_platform/api/platform/lf_STM32f4_support.h
naichenzhao 895a8fb
Update low_level_platform/impl/src/lf_STM32f4_support.c
naichenzhao 0d3af6d
Update low_level_platform/api/platform/lf_STM32f4_support.h
naichenzhao 50603d7
Update low_level_platform/impl/src/lf_STM32f4_support.c
naichenzhao cba9193
resolved some more comments
naichenzhao cf36f59
changed macro
naichenzhao 6e9e3c7
Merge branch 'main' into stm32
naichenzhao 6974d8e
Merge branch 'main' into stm32
naichenzhao a2e1e4b
Merge branch 'stm32' of https://github.com/lf-lang/reactor-c into stm32
naichenzhao 68ec2d7
Run clang-format
erlingrj 2d23659
Update lf-ref to the new lf branch
erlingrj 128e9a4
Merge branch 'main' into stm32
erlingrj 22b871d
Refactor comments
erlingrj 68bd26a
Dont rely on hardcoded relative path to the "STM_SDK"
erlingrj 335d52b
Remove all the STM32 cmake setup from reactor-c. This happens outside
erlingrj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A timer prescaler is typically loaded without a guard, meaning that it won't take event until the next update event of the clock. This is meant to ensure the prescaler doesn't take effect mid-phase, which could cause strange artifacts in your application. When you enable the peripheral, it will start with whatever was in the prescaler register at the time it was enabled, possibly leading to a large delay before the timer ISR fires. The new prescaler value will be loaded after the preceding update event.
I'm not intimately familiar with this chipset, but generally hardware peripherals are configured first and then enabled. You may consider loading the prescaler before you enable the counter. If that doesn't work, a reset is fine, but I suggest a simpler comment "reset to effect new prescaler".
This is important in safety-critical systems, you need to know when your I/O is stable and safe to use. This is known as "I/O stability".