Refactoring of obsolete gethostbyname()
in connect_to_rti()
#220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the linux man-page:
Currently, gethostbyname() is used in connect_to_rti(). This PR modifies the function to use getaddrinfo() instead. The functionality should be unchanged. If no host matches the given hostname, getaddrinfo() will return a non-zero value and exit. If at least one address structure matches the given hostname, it will set the port the be uport and try to connect. Notice that getaddrinfo() returns a linked list of matching address structures, if more than one matches the hostname and hints. According to the man page:
So in the current application, I think it should never return more than one address structure (the hints structure specifies AF_INET and SOCK_STREAM specifically). And if it does, we essentially ignore all but the first one, and if the first one fails, try with the next port number instead.