Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Introduce the next downstream tag (NDT) to optimize the communication in centralized federated execution #176

Closed
wants to merge 67 commits into from
Closed

Draft: Introduce the next downstream tag (NDT) to optimize the communication in centralized federated execution #176

wants to merge 67 commits into from

Conversation

byeonggiljun
Copy link
Collaborator

@byeonggiljun byeonggiljun commented Mar 8, 2023 •
edited
Loading

This draft PR tries to remove unnecessary LTC messages from federates to the RTI.
To do this, the RTI has to forward NET messages to indicate when the LTC message is needed.

For more information, please see this discussion, lingua-franca/discussions/1626.

  • TODOs

    • Make docker tests use the changed RTI instead of from the docker server
    • Support tracing for NDT messages
    • Add unit tests for testing this NDT handling protocol
    • RTI
    • Scanning transitive upstream federates when sending NDTs and checking the cycle
    • When receiving NET at g, send NDT to upstream federates that did not complete the tag g
    • Trace the sparsity of the message to determine the need for NDT messages
    • Don't send NDT messages to a federate when it has a downstream with a physical action
    • (For further optimization) Discuss how to not send unnecessary NDTs and implement the solution
    • Federate
    • Create ndt_queue to manage NDTs
    • Do not insert the duplicate tags inside the ndt_q
    • Eliminate unnecessary NET, LTC, and ABS messages based on information from ndt_queue
    • Handle corner case that NDT earlier than the current tag is received

@byeonggiljun byeonggiljun mentioned this pull request Mar 8, 2023
Merged
@byeonggiljun byeonggiljun self-assigned this Apr 18, 2023
@byeonggiljun byeonggiljun linked an issue Aug 31, 2023 that may be closed by this pull request
Optimizing Centralized Federated Execution #264
Open
5 tasks
@byeonggiljun byeonggiljun changed the title Draft: Remove unnecessary LTC messages to optimize the RTI Draft: Introduce the next downstream tag (NDT) to optimize the communication in centralized federated execution Oct 2, 2023
@byeonggiljun byeonggiljun added enhancement Enhancement of existing feature federated labels Nov 15, 2023
@byeonggiljun byeonggiljun changed the base branch from main to pqueue-refactoring November 15, 2023 06:10
@byeonggiljun byeonggiljun mentioned this pull request Nov 20, 2023
Draft
2 tasks
Base automatically changed from pqueue-refactoring to main November 25, 2023 07:21
@byeonggiljun byeonggiljun mentioned this pull request Jan 23, 2024
Closed
@byeonggiljun
Copy link
Collaborator Author

This PR is substituted by #337.

@byeonggiljun byeonggiljun mentioned this pull request Feb 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee left review comments

Assignees

@byeonggiljun byeonggiljun

Labels
enhancement Enhancement of existing feature federated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizing Centralized Federated Execution
2 participants
@byeonggiljun @edwardalee