Skip to content

Commit

Permalink
[benchmarks] Minor repairs.
Browse files Browse the repository at this point in the history
  • Loading branch information
petervdonovan committed Jul 18, 2022
1 parent 35ad9b0 commit aee4059
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/actions/run-benchmarks/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ runs:
cd ..
if [[ -z $EXISTING_FILE ]]; then
mkdir -p ${{ inputs.repo-for-saving-data }}/$OUTPUT_DIR
echo "The collected benchmark results will be saved to $OUTPUT_FILE."
echo "The collected benchmark results will be saved to $OUTPUT_DIR/$OUTPUT_FILENAME."
echo "::set-output name=output-file::$OUTPUT_DIR/$OUTPUT_FILENAME"
else
echo "The benchmark will not be run because results for that commit are already saved at $EXISTING_FILE."
Expand Down
12 changes: 7 additions & 5 deletions .github/actions/visualize-save-upload/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,11 @@ runs:
run: |
echo $(ls)
if [ -f errors.txt ]; then
ERROR_MESSAGES=$(cat errors.txt)
echo "The benchmark runner reported the following errors:\n$ERROR_MESSAGES"
echo "::set-output name=error-messages::Error messages: $ERROR_MESSAGES"
ERROR_MESSAGES="The benchmark runner reported the following errors:"$'\n'"$(cat errors.txt)"
echo "$ERROR_MESSAGES"
echo 'ERROR_MESSAGES<<EOF' >> $GITHUB_ENV
echo "$ERROR_MESSAGES" >> $GITHUB_ENV
echo 'EOF' >> $GITHUB_ENV
fi
shell: bash

Expand All @@ -70,7 +72,7 @@ runs:
with:
message: |
Running benchmarks from commit ${{ github.sha }}...
${{ steps.compute-error-messages.outputs.error-messages }}
${{ env.ERROR_MESSAGES }}
Results so far:
Expand All @@ -85,7 +87,7 @@ runs:
with:
message: |
:heavy_check_mark: Finished running benchmarks from ${{ github.sha }}.
${{ steps.compute-error-messages.outputs.error-messages }}
${{ env.ERROR_MESSAGES }}
![Visualization of the benchmark results.](https://raw.githubusercontent.com/lf-lang/${{ inputs.repo-for-saving-data }}/saved-benchmark-results/${{ steps.figure.outputs.output-file }})
comment_includes: ${{ github.sha }}
Expand Down

0 comments on commit aee4059

Please sign in to comment.