CI updated to include commit SHA in version number when creating nightly build #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axmmisaka
force-pushed
the
snapshot-show-commit-as-well
branch
from
b774503
to
40a8130
Compare
erlingrj
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Cool, thanks for looking at this @axmmisaka. I don't think your approach is hacky at all! I suggest that we format it a little "cleaner" and adds the date of the build. This is also how rustc --version looks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like sticking a big piece of duct tape on a giant pile of duct tapes, but I think this is the only way I could think of that could fix #2066.
If there are ways to pass the commit SHA in as gradle/compiler property for the compiler to use, I'm all ears.
Result:
