Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems with assignment serialization in diagrams #2038

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Fix problems with assignment serialization in diagrams #2038

merged 3 commits into from
Oct 5, 2023

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Oct 4, 2023

Fixes handling of ToLf class that is used to serialize initialization assignments in parameters and state variables for diagrams.

Closes #2010
Closes #2029

@a-sr a-sr added diagrams Problems with diagram synthesis bugfix labels Oct 4, 2023
@a-sr a-sr added this to the 0.6.0 milestone Oct 4, 2023
@a-sr a-sr requested a review from lhstrh October 4, 2023 16:41
cmnrd
cmnrd approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This takes care of the problem nicely and also forks for the alternative initialization options in C++. Thanks for the fix!

@cmnrd cmnrd added this pull request to the merge queue Oct 5, 2023
Merged via the queue into master with commit f00e8ab Oct 5, 2023
41 checks passed
@cmnrd cmnrd deleted the diagrams-assignment-serialization-fix branch October 5, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnrd cmnrd cmnrd approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
bugfix diagrams Problems with diagram synthesis
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Enabling StateVars in Diagram throws Exception Parameters not rendered correctly
2 participants
@a-sr @cmnrd