Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of caching across runs using gradle-build-action #1960

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Aug 18, 2023

Fixes #1898.

The default behavior of this action is to only write the cache on main/master, but this leads to cache misses and the associated network errors that occur when downloading stuff, so we allow writing to the cache in all branches currently. We should keep and eye on this and make adjustments down the road..

@lhstrh lhstrh marked this pull request as ready for review August 18, 2023 20:43
@lhstrh lhstrh force-pushed the windows-cache branch 5 times, most recently from 9d3e8c9 to 9503246 Compare August 28, 2023 19:38
@lhstrh lhstrh changed the title [CI] Caching on Windows Handling of caching across runs using gradle-build-action Aug 28, 2023
@lhstrh lhstrh added the ci Continuous integration label Aug 28, 2023
@lhstrh lhstrh requested a review from axmmisaka August 28, 2023 20:08
Copy link
Collaborator

@axmmisaka axmmisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, it uses steps that are officially supported, so that this CI step is concise, updated, and eliminated the need to reinvent wheels. If CI passes then I'm all for it!

@lhstrh lhstrh enabled auto-merge August 28, 2023 22:32
@lhstrh lhstrh added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@lhstrh lhstrh enabled auto-merge August 29, 2023 05:54
@lhstrh lhstrh added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit eb3a5d3 Aug 29, 2023
40 checks passed
@lhstrh lhstrh deleted the windows-cache branch August 29, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Fix caching on Windows hosts
2 participants