Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): extract process start/end hook #3285

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

ngjaying
Copy link
Collaborator

Make it possible to add common hook functionalities for all nodes

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.87%. Comparing base (f1ee479) to head (ffd7a0c).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/node/event_window_trigger.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
- Coverage   70.95%   70.87%   -0.07%     
==========================================
  Files         397      397              
  Lines       44701    44648      -53     
==========================================
- Hits        31714    31644      -70     
- Misses      10473    10485      +12     
- Partials     2514     2519       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Make it possible to add common hook functionalities for all nodes

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying requested a review from Yisaer October 11, 2024 09:53
@ngjaying ngjaying marked this pull request as ready for review October 11, 2024 09:53
@ngjaying ngjaying merged commit 7efb9c4 into lf-edge:master Oct 12, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants