Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace ruleJson's password/url #3251

Merged
merged 5 commits into from
Sep 29, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Sep 27, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review September 27, 2024 09:03
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (b898083) to head (f5ace32).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/replace/replace.go 86.44% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   70.85%   70.84%   -0.01%     
==========================================
  Files         395      396       +1     
  Lines       44335    44475     +140     
==========================================
+ Hits        31411    31506      +95     
- Misses      10430    10468      +38     
- Partials     2494     2501       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit e45da75 into lf-edge:master Sep 29, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants