Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revise rule trace api #3193

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: revise rule trace api #3193

merged 2 commits into from
Sep 13, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Sep 12, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (f1678cc) to head (d0afad4).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/rest.go 63.33% 8 Missing and 3 partials ⚠️
internal/topo/rule/state.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3193      +/-   ##
==========================================
- Coverage   71.14%   70.84%   -0.29%     
==========================================
  Files         386      386              
  Lines       43638    43685      +47     
==========================================
- Hits        31043    30948      -95     
- Misses      10139    10273     +134     
- Partials     2456     2464       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/server/rest_test.go Show resolved Hide resolved
internal/topo/context/default.go Outdated Show resolved Hide resolved
Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit bcc2170 into lf-edge:master Sep 13, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants