Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connection): remove detachSub #3172

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Sep 5, 2024

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying force-pushed the v2connection branch 3 times, most recently from 6ad4311 to cc5c875 Compare September 5, 2024 07:57
Each client can implement its own if needed.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Do not need to report error

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 89.91228% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.11%. Comparing base (7248c66) to head (f1b34df).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/connection/pool.go 93.28% 6 Missing and 3 partials ⚠️
pkg/connection/mock.go 42.86% 4 Missing ⚠️
extensions/impl/sql/sink.go 0.00% 3 Missing ⚠️
internal/io/http/httpserver/httpconn.go 40.00% 3 Missing ⚠️
internal/io/http/httpserver/websocketConn.go 50.00% 2 Missing ⚠️
internal/io/mqtt/source.go 50.00% 1 Missing ⚠️
internal/server/server.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3172      +/-   ##
==========================================
- Coverage   71.13%   71.11%   -0.02%     
==========================================
  Files         385      386       +1     
  Lines       43187    43210      +23     
==========================================
+ Hits        30721    30728       +7     
- Misses      10033    10047      +14     
- Partials     2433     2435       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying requested a review from Yisaer September 5, 2024 10:08
@ngjaying ngjaying marked this pull request as ready for review September 5, 2024 10:08
@ngjaying ngjaying merged commit 0d5c110 into lf-edge:master Sep 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants