Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support update tracer #3166

Merged
merged 5 commits into from
Sep 4, 2024
Merged

feat: support update tracer #3166

merged 5 commits into from
Sep 4, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Sep 3, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 45.91837% with 53 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (b14761a) to head (63612a6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/tracer/tracer.go 56.52% 26 Missing and 4 partials ⚠️
internal/server/tracer.go 0.00% 17 Missing ⚠️
internal/conf/yaml_config_storage.go 45.45% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
+ Coverage   71.10%   71.12%   +0.02%     
==========================================
  Files         385      385              
  Lines       43064    43142      +78     
==========================================
+ Hits        30618    30683      +65     
- Misses      10028    10034       +6     
- Partials     2418     2425       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serialize the configuration

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serialize the configuration

Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit 9e2d873 into lf-edge:master Sep 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants