Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix metrics for batch operator #3144

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: fix metrics for batch operator #3144

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea8464
fix
Yisaer Aug 27, 2024
bd5cdcf
address the comment
Yisaer Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/topo/node/batch_op.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ func (b *BatchOp) ingest(ctx api.StreamContext, item any, checkSize bool) {
b.currIndex++
if checkSize && b.currIndex >= b.batchSize {
b.send(ctx)
b.statManager.IncTotalRecordsOut()
}
b.statManager.ProcessTimeEnd()
b.statManager.IncTotalMessagesProcessed(1)
Expand All @@ -150,6 +149,7 @@ func (b *BatchOp) send(ctx api.StreamContext) {
panic("shouldn't send message when empty")
})
b.handleTraceEmitTuple(ctx, b.buffer)
b.statManager.IncTotalRecordsOut()
ngjaying marked this conversation as resolved.
Show resolved Hide resolved
b.Broadcast(b.buffer)
// Reset buffer
b.buffer = &xsql.WindowTuples{
Expand Down
Loading