Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use prepared stmt in sql #3100

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Aug 15, 2024

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.12%. Comparing base (10aa246) to head (b11c83d).
Report is 11 commits behind head on master.

Files Patch % Lines
internal/pkg/store/sql/sqlKv.go 63.16% 4 Missing and 3 partials ⚠️
internal/pkg/store/sql/sqlTs.go 60.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
- Coverage   68.14%   68.12%   -0.02%     
==========================================
  Files         391      391              
  Lines       37014    37031      +17     
==========================================
+ Hits        25221    25227       +6     
- Misses       9547     9553       +6     
- Partials     2246     2251       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change the SQL plugin as well?

@Yisaer
Copy link
Collaborator Author

Yisaer commented Aug 15, 2024

Do we need to change the SQL plugin as well?

I think it's not necessary, the query is generated by kuiperd itself.

@ngjaying ngjaying merged commit 0c5e010 into lf-edge:master Aug 16, 2024
21 of 22 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Aug 20, 2024
Signed-off-by: Song Gao <disxiaofei@163.com>
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Aug 20, 2024
Signed-off-by: Song Gao <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Aug 20, 2024
Signed-off-by: Song Gao <disxiaofei@163.com>
Crispy-fried-chicken added a commit to Crispy-fried-chicken/ekuiper that referenced this pull request Aug 22, 2024
Crispy-fried-chicken added a commit to Crispy-fried-chicken/ekuiper that referenced this pull request Aug 22, 2024
cherry-picked from commit 1a9c745

Signed-off-by: Yiheng Cao <65160922+Crispy-fried-chicken@users.noreply.github.com>
Crispy-fried-chicken added a commit to Crispy-fried-chicken/ekuiper that referenced this pull request Aug 22, 2024
cherry-picked from commit 1a9c745

Signed-off-by: Yiheng Cao <65160922+Crispy-fried-chicken@users.noreply.github.com>
Crispy-fried-chicken added a commit to Crispy-fried-chicken/ekuiper that referenced this pull request Aug 22, 2024
Crispy-fried-chicken added a commit to Crispy-fried-chicken/ekuiper that referenced this pull request Aug 22, 2024
cherry-picked from commit 1a9c745

Signed-off-by: Yiheng Cao <65160922+Crispy-fried-chicken@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants