Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(io): add file source in lines mode #2866

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 78.53659% with 44 lines in your changes are missing coverage. Please review.

Please upload report for BASE (master-v2@3147d8c). Learn more about missing BASE report.

Files Patch % Lines
internal/io/file/source.go 78.95% 27 Missing and 13 partials ⚠️
pkg/mock/test_source.go 71.43% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master-v2    #2866   +/-   ##
============================================
  Coverage             ?   68.86%           
============================================
  Files                ?      274           
  Lines                ?    26032           
  Branches             ?        0           
============================================
  Hits                 ?    17926           
  Misses               ?     6500           
  Partials             ?     1606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying force-pushed the v2source branch 14 times, most recently from 311ab21 to 2ba1af6 Compare May 22, 2024 07:02
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review May 22, 2024 07:57
@ngjaying ngjaying requested a review from Yisaer May 22, 2024 07:57
@ngjaying ngjaying merged commit bca96e0 into lf-edge:master-v2 May 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants