fix: ignore nil value in array convert #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: carlclone <906561974@qq.com>
Signed-off-by: carlclone <906561974@qq.com>
Signed-off-by: carlclone <906561974@qq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
- Coverage 63.58% 63.18% -0.39%
==========================================
Files 340 346 +6
Lines 39015 39323 +308
==========================================
+ Hits 24804 24845 +41
- Misses 12043 12306 +263
- Partials 2168 2172 +4 ☔ View full report in Codecov by Sentry. |
ngjaying
reviewed
Mar 29, 2024
pkg/cast/cast.go
Outdated
| @@ -905,14 +913,22 @@ func ToUint64Slice(input interface{}, sn Strictness) ([]uint64, error) { | |||
| return result, nil | |||
| } | |||
|
|
|||
| func ToFloat64Slice(input interface{}, sn Strictness) ([]float64, error) { | |||
| func ToFloat64Slice(input interface{}, sn Strictness, anc ARRAY_NIL_CONVERT) ([]float64, error) { | |||
There was a problem hiding this comment.
Shall we make similar changes to other ToXXXSlice functions?
There was a problem hiding this comment.
Those methods don't seem to affect the aggregation function. Should I modified them ? maybe in a new pull request .
Signed-off-by: carlclone <906561974@qq.com>
Signed-off-by: carlclone <906561974@qq.com>
ngjaying
pushed a commit
to ngjaying/kuiper
that referenced
this pull request
Apr 22, 2024
Signed-off-by: carlclone <906561974@qq.com>
ngjaying
pushed a commit
that referenced
this pull request
Apr 22, 2024
Signed-off-by: carlclone <906561974@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.