Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the help, when the create_context command was not entered with al… #337

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

tdrozdovsky
Copy link
Contributor

…l the parameters

Signed-off-by: Taras Drozdovskyi t.drozdovsky@samsung.com

Description

An entered prompt if the context is not exixst or create_context command was entered without CONFIGFILE

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Absent .config
$ make distclean
$ make 
Edge-Orchestration has not been configured:
  make create_context CONFIGFILE=<configfile>

Makefile:263: recipe for target 'check_context' failed
make: *** [check_context] Error 1
  1. Enter create_context without CONFIGFILE
$ make create_context

CONFIGFILE not been specified:
  make create_context CONFIGFILE=<configfile>

Makefile:255: recipe for target '.config' failed
make: *** [.config] Error 1

Test Configuration:

  • Firmware version: Ubuntu 18.04
  • Hardware: x86-64
  • Edge Orchestration Release: Coconut

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
Not Found
…l the parameters

Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
@tdrozdovsky tdrozdovsky added the bug Something isn't working label Jul 16, 2021
@tdrozdovsky tdrozdovsky self-assigned this Jul 16, 2021
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
This PR contains guidelines for handleing errors during make.

Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@MoonkiHong MoonkiHong merged commit f2c562e into lf-edge:master Jul 21, 2021
@tdrozdovsky tdrozdovsky deleted the fix-create-context branch July 26, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants