Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inaccuracies founded by Go Report Card system #288

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Fix inaccuracies founded by Go Report Card system #288

merged 1 commit into from
Mar 28, 2021

Conversation

tdrozdovsky
Copy link
Contributor

Signed-off-by: Taras Drozdovskyi t.drozdovsky@gmail.com

Description

Fix inaccuracies founded by Go Report Card system

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Code cleanup/refactoring

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fix inaccuracies founded by Go Report Card system
d554b70 
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@gmail.com>
@tdrozdovsky tdrozdovsky added the refactoring Any tasks and issues w.r.t. the code refactoring label Mar 23, 2021
@tdrozdovsky tdrozdovsky self-assigned this Mar 23, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@tiokim tiokim mentioned this pull request Mar 23, 2021
Closed
tiokim
tiokim approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

suresh-lc
suresh-lc approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@suresh-lc suresh-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine

MoonkiHong
MoonkiHong approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MoonkiHong MoonkiHong merged commit ab0e69d into lf-edge:master Mar 28, 2021
@tdrozdovsky tdrozdovsky deleted the fix-inaccuracies branch July 8, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suresh-lc suresh-lc suresh-lc approved these changes

@MoonkiHong MoonkiHong MoonkiHong approved these changes

@tiokim tiokim tiokim approved these changes

@mgjeong mgjeong Awaiting requested review from mgjeong

Assignees

@tdrozdovsky tdrozdovsky

Labels
refactoring Any tasks and issues w.r.t. the code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdrozdovsky @tiokim @MoonkiHong @suresh-lc