Bump whitaker-installer to 0.2.6 - #17
Merged
Merged
Conversation
Installer 0.2.5 provisions cargo-dylint 4.1.0, whose dylint driver cannot build on the suite's new nightly-2026-05-28 pin; 0.2.6 provisions cargo-dylint 6.0.1.
leynos
enabled auto-merge (squash)
July 17, 2026 20:07
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Summary
WalkthroughThe PR updates the Whitaker installer used by CI, standardises documentation to “artefacts”, and expands generated Typos ignore patterns and spelling mappings. ChangesCI installer update
Spelling policy updates
Possibly related PRs
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (18 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The shared en-GB-oxendict typos dictionary was recently updated, dropping the "artifact"/"artifacts" allow-word entries and surfacing four pre-existing spellings in docs/limela-pipeline-design.md that the gate now flags. Corrected each occurrence to the Oxford spelling "artefacts"; all four were genuine prose (email cleanup residue, deployment artefacts, blob data artefacts, regex-removed noise), so no typos.local.toml exception was needed. typos.toml is regenerated by scripts/generate_typos_config.py from the refreshed shared dictionary and is committed as produced.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@typos.toml`:
- Around line 34-39: Add a regression test in the test_typos_rollout.py test
suite that runs the typos checker against a fixture containing fenced code,
inline code, rust-analyzer, and the allow-listed terms from typos.toml. Assert
the expected checker behavior for each case, while preserving the existing
configuration parsing and rendering tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cd3e2e59-7203-4c90-82df-2e6ca8d52d3f
📒 Files selected for processing (3)
.github/workflows/ci.ymldocs/limela-pipeline-design.mdtypos.toml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
leynos/whitaker(auto-detected)
Comment on lines
+34
to
+39
| "\\brust-analyzer\\b", | ||
| "`[^`\\n]+`", | ||
| ] | ||
|
|
||
| [default.extend-words] | ||
| "ASO" = "ASO" |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'FILES:\n'
git ls-files | rg '(^|/)(typos\.toml|.*typos.*|.*spell.*|.*typo.*|Makefile|scripts/typos_rollout\.py|.*test.*|.*spec.*)$' || true
printf '\nTYPOS TOML:\n'
nl -ba typos.toml | sed -n '1,220p'
printf '\nSEARCH artifact/artifacts/ignore words:\n'
rg -n '"artifact|artifacts|rust-analyzer|ASO|ignore-regex|extend-words|typos' . || trueRepository: leynos/limela
Length of output: 504
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'TYPOS TOML:\n'
sed -n '1,220p' typos.toml
printf '\nLOCAL TYPOS TOML:\n'
sed -n '1,220p' typos.local.toml
printf '\nROLL OUT TESTS:\n'
sed -n '1,260p' scripts/tests/test_typos_rollout.py
printf '\nSEARCH RELEVANT REFERENCES:\n'
rg -n 'artifact|artifacts|rust-analyzer|ASO|extend-words|ignore-regex|typos' scripts tests .github . || trueRepository: leynos/limela
Length of output: 25385
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- typos.toml ---'
sed -n '1,220p' typos.toml
echo
echo '--- scripts/tests/test_typos_rollout.py ---'
sed -n '1,260p' scripts/tests/test_typos_rollout.py
echo
echo '--- grep relevant references ---'
rg -n 'artifact|artifacts|rust-analyzer|ASO|extend-words|ignore-regex|typos' typos.toml typos.local.toml scripts tests .github || trueRepository: leynos/limela
Length of output: 20461
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- Makefile relevant section ---'
sed -n '40,80p' Makefile
echo
echo '--- GitHub workflow references to typos/spellcheck ---'
rg -n 'typos|spellcheck|generate_typos_config|typos\.toml' .github Makefile scripts -g '!scripts/tests/test_typos_rollout.py'
echo
echo '--- generate_typos_config.py ---'
sed -n '1,220p' scripts/generate_typos_config.pyRepository: leynos/limela
Length of output: 7640
Add a regression test in scripts/tests/test_typos_rollout.py.
Exercise typos.toml with a fixture that hits fenced code, inline code, rust-analyzer, and the new allow-listed terms, so the checker behaviour stays covered. The current tests only parse and render the config.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@typos.toml` around lines 34 - 39, Add a regression test in the
test_typos_rollout.py test suite that runs the typos checker against a fixture
containing fenced code, inline code, rust-analyzer, and the allow-listed terms
from typos.toml. Assert the expected checker behavior for each case, while
preserving the existing configuration parsing and rendering tests.
Source: Coding guidelines
This was referenced Jul 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request bumps the pinned Whitaker installer version from 0.2.5 to 0.2.6, because the Whitaker Dylint suite's rolling release now pins toolchain
nightly-2026-05-28, which requirescargo-dylint6.0.1. Installer 0.2.5 provisionscargo-dylint4.1.0, whose driver cannot be compiled on that nightly, so the repository's CI lint step has been red until this bump lands.whitaker-installer0.2.6 fixes this, and its prebuilt dependency binaries are now published.Changed files
.github/workflows/ci.yml