Add syrupy snapshot tests for 'already published' warning in _handle_publish_result

[coderabbitai]

Background

tests/unit/publish/test_snapshot_messages.py already uses syrupy to lock
in the exact format of index-lookup and validation messages. The
"already published" warning path in _handle_publish_result (in
lading/commands/publish.py) is not yet covered by any snapshot test, so
its message format is unconstrained.

Scope

Add one or more syrupy snapshot tests to
tests/unit/publish/test_snapshot_messages.py (following the existing
_warning_records pattern) that exercise the already-published warning
branch of _handle_publish_result and lock in the exact warning message
via snapshot().

References

• PR: Interleave live publish packaging (#59) #70
• Raised by: @leynos

[coderabbitai]

🔗 Related PRs

leynos/ghillie#60 - Plan ghillie migration to femtologging (ExecPlan added) [merged]
#63 - Document and detect dry-run failures with unindexed sibling crates (#60) [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[leynos]

@CodeRabbit plan

[coderabbitai]

Coding Plan

Summary

• Follow the established _warning_records + syrupy pattern already used for index-missing-version warnings
• Create a minimal stderr constant that triggers _is_already_published_error (exit code 101 plus a marker string)
• Call _handle_publish_result directly with controlled inputs to isolate the already-published branch
• Snapshot the unformatted warning message and arguments to lock in the exact format

Implementation Steps

Add Snapshot Test for Already-Published Warning

Add a single focused test that exercises the already-published warning path in _handle_publish_result, following the established patterns for snapshot message testing.

Task 1: Add Already-Published Stderr Constant

Define a constant representing Cargo's stderr output when a crate version is already published.

• Add ALREADY_PUBLISHED_STDERR constant to tests/unit/publish/conftest.py, following the naming convention of existing constants (INDEX_MISSING_STDERR_BETA, etc.)
• The constant must contain one of the _ALREADY_PUBLISHED_MARKERS strings (e.g., "already exists on crates.io") to trigger _is_already_published_error
• Export the constant via the module's __all__ list or ensure it is importable

Task 2: Add Snapshot Test Function

Create a test function that captures and snapshots the already-published warning.

• Add test_already_published_warning_snapshot to tests/unit/publish/test_snapshot_messages.py
• Import the new ALREADY_PUBLISHED_STDERR constant from .conftest
• Use the publish_plan_and_prep fixture to obtain a PublishPlan and access a WorkspaceCrate with known name and version values
• Construct a publish._CargoInvocation with:
  • crate_name matching the crate under test
  • subcommand set to "publish"
  • output tuple of (101, "", ALREADY_PUBLISHED_STDERR) — exit code 101 triggers the registry error path
• Invoke publish._handle_publish_result directly, passing the invocation, crate, plan, and a publish._PublishExecutionOptions instance (with live=False or live=True)
• Capture warning records via _warning_records(caplog) and assert against snapshot()
• The test must not raise an exception; the already-published path is a non-fatal downgrade

🤖 Prompt for AI agents

Add a snapshot test for the already-published warning branch of
`_handle_publish_result`, following the exact patterns already established in
`tests/unit/publish/test_snapshot_messages.py`.

**Task 1 — Add `ALREADY_PUBLISHED_STDERR` to `tests/unit/publish/conftest.py`:**
- Define the constant following the naming convention of existing constants such
as `INDEX_MISSING_STDERR_BETA`
- The value must contain one of the `_ALREADY_PUBLISHED_MARKERS` strings (e.g.,
`"already exists on crates.io"`) so that `_is_already_published_error` is
triggered
- Ensure the constant is importable (add to `__all__` if the module uses one)

**Task 2 — Add `test_already_published_warning_snapshot` to
`tests/unit/publish/test_snapshot_messages.py`:**
- Import `ALREADY_PUBLISHED_STDERR` from `.conftest`
- Accept the `publish_plan_and_prep` fixture to obtain a `PublishPlan` and a
`WorkspaceCrate` with known `name` and `version` values
- Construct a `publish._CargoInvocation` with:
  - `crate_name` matching the crate under test
  - `subcommand` set to `"publish"`
- `output` as the tuple `(101, "", ALREADY_PUBLISHED_STDERR)` — exit code 101
triggers the registry error path
- Call `publish._handle_publish_result` directly, passing the invocation, the
crate, the plan, and a `publish._PublishExecutionOptions` instance
- Capture warning records with `_warning_records(caplog)` and assert the result
against `snapshot()`
- Confirm the call does not raise; the already-published path is a non-fatal
downgrade

Research

The publish test suite in tests/unit/publish/ uses syrupy for snapshot regression testing of message formats. The conftest.py file provides shared fixtures including make_crate (creates WorkspaceCrate instances), publish_plan_and_prep (provides a three-crate dependency chain), and _warning_records (captures warning-level log records as (msg, args) tuples). Existing snapshot tests in test_snapshot_messages.py import the publish module and invoke private functions directly (e.g., publish._handle_index_missing_version), constructing publish._CargoInvocation instances with specific exit codes and stderr content to trigger particular code paths.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Add a snapshot test for the already-published warning branch of
`_handle_publish_result`, following the exact patterns already established in
`tests/unit/publish/test_snapshot_messages.py`.

**Task 1 — Add `ALREADY_PUBLISHED_STDERR` to `tests/unit/publish/conftest.py`:**
- Define the constant following the naming convention of existing constants such
as `INDEX_MISSING_STDERR_BETA`
- The value must contain one of the `_ALREADY_PUBLISHED_MARKERS` strings (e.g.,
`"already exists on crates.io"`) so that `_is_already_published_error` is
triggered
- Ensure the constant is importable (add to `__all__` if the module uses one)

**Task 2 — Add `test_already_published_warning_snapshot` to
`tests/unit/publish/test_snapshot_messages.py`:**
- Import `ALREADY_PUBLISHED_STDERR` from `.conftest`
- Accept the `publish_plan_and_prep` fixture to obtain a `PublishPlan` and a
`WorkspaceCrate` with known `name` and `version` values
- Construct a `publish._CargoInvocation` with:
  - `crate_name` matching the crate under test
  - `subcommand` set to `"publish"`
- `output` as the tuple `(101, "", ALREADY_PUBLISHED_STDERR)` — exit code 101
triggers the registry error path
- Call `publish._handle_publish_result` directly, passing the invocation, the
crate, the plan, and a `publish._PublishExecutionOptions` instance
- Capture warning records with `_warning_records(caplog)` and assert the result
against `snapshot()`
- Confirm the call does not raise; the already-published path is a non-fatal
downgrade

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!