Feature request: lading bump should update [workspace.dependencies]

[leynos]

Summary

Please extend lading bump to update version entries inside
[workspace.dependencies], [[workspace.dependencies]] (if present), and
optionally the corresponding workspace.dev-dependencies / workspace.build-dependencies
sections. Today, only [dependencies], [dev-dependencies], and
[build-dependencies] inside manifests are updated.

Motivation

Workspaces that centralize dependency versions in [workspace.dependencies]
expect a single lading bump run to keep all version references consistent.
In the current behaviour, workspace entries are left unchanged, which can be
misleading for crates that rely on workspace dependency inheritance (e.g.
dependency.workspace = true). It also means internal path dependencies
specified in [workspace.dependencies] can remain stale.

Current behaviour

• lading bump updates [package].version in workspace members.
• It updates dependency versions in [dependencies], [dev-dependencies], and
  [build-dependencies] in each manifest.
• It does not update [workspace.dependencies] in the root Cargo.toml.

Expected behaviour

• When lading bump <version> is run, the tool should also update version
  entries for workspace crates in [workspace.dependencies] (and, ideally,
  workspace.dev-dependencies / workspace.build-dependencies).

Proposed approach

• Extend the dependency section list in the bump logic to include
  workspace.dependencies (and the dev/build variants).
• Reuse the existing dependency update logic to keep behaviour consistent with
  crate-level dependency sections.

Optional configuration

If desired, this could be gated behind a config flag, but defaulting to “on”
would match expectations for workspace-managed dependency versions.

[traycerai]

Plan

Observations

The lading bump command currently updates [package].version and dependency versions in [dependencies], [dev-dependencies], and [build-dependencies] sections within each crate manifest. The workspace root manifest is also processed, but only for these standard sections. The code uses _workspace_dependency_sections() (file:lading/commands/bump.py, lines 372-383) to determine which sections to update in the workspace manifest, but it does not include [workspace.dependencies] or its dev/build variants. The existing _select_table() function (lines 688-704) already supports nested table navigation using tuple paths like ("workspace", "dependencies"), and _update_dependency_sections() (lines 411-425) can be easily extended to handle dot-notation section names.

Approach

Extend the bump logic to include workspace dependency sections by modifying _workspace_dependency_sections() to return additional entries for workspace.dependencies, workspace.dev-dependencies, and workspace.build-dependencies. Update _update_dependency_sections() to parse dot-notation section names and convert them to tuple paths for _select_table(). This approach reuses existing infrastructure, requires minimal code changes, and maintains backward compatibility. The feature will be enabled by default, matching the expected behavior for workspace-managed dependency versions as described in the issue.

Implementation Steps

1. Modify _workspace_dependency_sections() Function

Location: file:lading/commands/bump.py, lines 372-383

Update the function to return both regular and workspace-prefixed dependency sections:

• Add three new entries to the returned dictionary with keys "workspace.dependencies", "workspace.dev-dependencies", and "workspace.build-dependencies"
• Each entry should map to the same set of crate names as the corresponding regular section
• The function should return 6 entries total (3 regular + 3 workspace sections)

2. Update _update_dependency_sections() Function

Location: file:lading/commands/bump.py, lines 411-425

Modify the function to handle dot-notation section names:

• Before calling _select_table() at line 421, split the section string by "." to create a tuple
• Replace table = _select_table(document, (section,)) with logic that:
  • Splits section by "." to get a tuple of keys (e.g., "workspace.dependencies" → ("workspace", "dependencies"))
  • Passes this tuple to _select_table()
• Ensure backward compatibility by handling single-element sections (e.g., "dependencies" → ("dependencies",))

3. Update Documentation String

Location: file:lading/commands/bump.py, line 379

Update the docstring for _workspace_dependency_sections() to reflect that it now returns both regular and workspace dependency sections.

4. Add Unit Tests

Location: file:tests/unit/test_bump_command_internals.py

Add test cases to verify the new functionality:

• Test that _workspace_dependency_sections() returns 6 entries (3 regular + 3 workspace)
• Test that _update_dependency_sections() correctly handles dot-notation section names
• Test that _select_table() is called with the correct tuple for workspace sections
• Test that workspace dependency versions are updated when present in the manifest
• Test that the function gracefully handles missing workspace sections (returns None from _select_table())

5. Add Integration Tests

Location: file:tests/unit/test_bump_command_integration.py or file:tests/bdd/steps/test_bump_steps.py

Create integration tests that verify end-to-end behavior:

• Create a test workspace with [workspace.dependencies] containing internal crate references
• Run lading bump <version> and verify that workspace dependency versions are updated
• Test with [workspace.dev-dependencies] and [workspace.build-dependencies]
• Verify that excluded crates are not updated in workspace sections
• Test dry-run mode to ensure workspace sections are reported correctly

6. Update Documentation Snippet Handling (Optional Enhancement)

Location: file:lading/commands/bump.py, lines 632-648

Consider updating _update_toml_snippet_dependencies() to also handle workspace dependency sections in documentation TOML fences. This ensures consistency when updating version references in README files and other documentation that may contain workspace dependency examples.

Implementation Flow

sequenceDiagram
    participant CLI as CLI Command
    participant Run as run()
    participant PWM as _process_workspace_manifest()
    participant WDS as _workspace_dependency_sections()
    participant UM as _update_manifest()
    participant UDS as _update_dependency_sections()
    participant ST as _select_table()
    participant UDT as _update_dependency_table()

    CLI->>Run: bump <version>
    Run->>PWM: Process workspace manifest
    PWM->>WDS: Get dependency sections
    WDS-->>PWM: Return 6 sections (regular + workspace)
    PWM->>UM: Update manifest with sections
    UM->>UDS: Update dependency sections
    loop For each section
        UDS->>UDS: Split section by "."
        UDS->>ST: Select table with tuple path
        ST-->>UDS: Return table or None
        alt Table exists
            UDS->>UDT: Update dependency table
            UDT-->>UDS: Return changed status
        end
    end
    UDS-->>UM: Return overall changed status
    UM-->>PWM: Return changed status
    PWM-->>Run: Complete

Loading

Key Files Modified

File	Lines	Changes
file:lading/commands/bump.py	372-383	Extend _workspace_dependency_sections() to return workspace sections
file:lading/commands/bump.py	411-425	Update _update_dependency_sections() to parse dot notation
file:tests/unit/test_bump_command_internals.py	New	Add unit tests for workspace section handling
file:tests/unit/test_bump_command_integration.py	New	Add integration tests for end-to-end verification

Backward Compatibility

This change is fully backward compatible:

• Existing manifests without [workspace.dependencies] will continue to work (the section simply won't exist, and _select_table() will return None)
• The dot-notation parsing handles both single-element sections (existing behavior) and multi-element sections (new behavior)
• No configuration changes are required
• No breaking changes to the API or command-line interface

Import In IDE

🤖 Prompt for AI Agents

## Observations

The `lading bump` command currently updates `[package].version` and dependency versions in `[dependencies]`, `[dev-dependencies]`, and `[build-dependencies]` sections within each crate manifest. The workspace root manifest is also processed, but only for these standard sections. The code uses `_workspace_dependency_sections()` (file:lading/commands/bump.py, lines 372-383) to determine which sections to update in the workspace manifest, but it does not include `[workspace.dependencies]` or its dev/build variants. The existing `_select_table()` function (lines 688-704) already supports nested table navigation using tuple paths like `("workspace", "dependencies")`, and `_update_dependency_sections()` (lines 411-425) can be easily extended to handle dot-notation section names.

## Approach

Extend the bump logic to include workspace dependency sections by modifying `_workspace_dependency_sections()` to return additional entries for `workspace.dependencies`, `workspace.dev-dependencies`, and `workspace.build-dependencies`. Update `_update_dependency_sections()` to parse dot-notation section names and convert them to tuple paths for `_select_table()`. This approach reuses existing infrastructure, requires minimal code changes, and maintains backward compatibility. The feature will be enabled by default, matching the expected behavior for workspace-managed dependency versions as described in the issue.

## Implementation Steps

### 1. Modify `_workspace_dependency_sections()` Function

**Location**: file:lading/commands/bump.py, lines 372-383

Update the function to return both regular and workspace-prefixed dependency sections:

- Add three new entries to the returned dictionary with keys `"workspace.dependencies"`, `"workspace.dev-dependencies"`, and `"workspace.build-dependencies"`
- Each entry should map to the same set of crate names as the corresponding regular section
- The function should return 6 entries total (3 regular + 3 workspace sections)

### 2. Update `_update_dependency_sections()` Function

**Location**: file:lading/commands/bump.py, lines 411-425

Modify the function to handle dot-notation section names:

- Before calling `_select_table()` at line 421, split the `section` string by `"."` to create a tuple
- Replace `table = _select_table(document, (section,))` with logic that:
  - Splits `section` by `"."` to get a tuple of keys (e.g., `"workspace.dependencies"` → `("workspace", "dependencies")`)
  - Passes this tuple to `_select_table()`
- Ensure backward compatibility by handling single-element sections (e.g., `"dependencies"` → `("dependencies",)`)

### 3. Update Documentation String

**Location**: file:lading/commands/bump.py, line 379

Update the docstring for `_workspace_dependency_sections()` to reflect that it now returns both regular and workspace dependency sections.

### 4. Add Unit Tests

**Location**: file:tests/unit/test_bump_command_internals.py

Add test cases to verify the new functionality:

- Test that `_workspace_dependency_sections()` returns 6 entries (3 regular + 3 workspace)
- Test that `_update_dependency_sections()` correctly handles dot-notation section names
- Test that `_select_table()` is called with the correct tuple for workspace sections
- Test that workspace dependency versions are updated when present in the manifest
- Test that the function gracefully handles missing workspace sections (returns `None` from `_select_table()`)

### 5. Add Integration Tests

**Location**: file:tests/unit/test_bump_command_integration.py or file:tests/bdd/steps/test_bump_steps.py

Create integration tests that verify end-to-end behavior:

- Create a test workspace with `[workspace.dependencies]` containing internal crate references
- Run `lading bump <version>` and verify that workspace dependency versions are updated
- Test with `[workspace.dev-dependencies]` and `[workspace.build-dependencies]`
- Verify that excluded crates are not updated in workspace sections
- Test dry-run mode to ensure workspace sections are reported correctly

### 6. Update Documentation Snippet Handling (Optional Enhancement)

**Location**: file:lading/commands/bump.py, lines 632-648

Consider updating `_update_toml_snippet_dependencies()` to also handle workspace dependency sections in documentation TOML fences. This ensures consistency when updating version references in README files and other documentation that may contain workspace dependency examples.

## Implementation Flow

```mermaid
sequenceDiagram
    participant CLI as CLI Command
    participant Run as run()
    participant PWM as _process_workspace_manifest()
    participant WDS as _workspace_dependency_sections()
    participant UM as _update_manifest()
    participant UDS as _update_dependency_sections()
    participant ST as _select_table()
    participant UDT as _update_dependency_table()

    CLI->>Run: bump <version>
    Run->>PWM: Process workspace manifest
    PWM->>WDS: Get dependency sections
    WDS-->>PWM: Return 6 sections (regular + workspace)
    PWM->>UM: Update manifest with sections
    UM->>UDS: Update dependency sections
    loop For each section
        UDS->>UDS: Split section by "."
        UDS->>ST: Select table with tuple path
        ST-->>UDS: Return table or None
        alt Table exists
            UDS->>UDT: Update dependency table
            UDT-->>UDS: Return changed status
        end
    end
    UDS-->>UM: Return overall changed status
    UM-->>PWM: Return changed status
    PWM-->>Run: Complete
```

## Key Files Modified

| File | Lines | Changes |
|------|-------|---------|
| file:lading/commands/bump.py | 372-383 | Extend `_workspace_dependency_sections()` to return workspace sections |
| file:lading/commands/bump.py | 411-425 | Update `_update_dependency_sections()` to parse dot notation |
| file:tests/unit/test_bump_command_internals.py | New | Add unit tests for workspace section handling |
| file:tests/unit/test_bump_command_integration.py | New | Add integration tests for end-to-end verification |

## Backward Compatibility

This change is fully backward compatible:
- Existing manifests without `[workspace.dependencies]` will continue to work (the section simply won't exist, and `_select_table()` will return `None`)
- The dot-notation parsing handles both single-element sections (existing behavior) and multi-element sections (new behavior)
- No configuration changes are required
- No breaking changes to the API or command-line interface

---

Execution Information

Branch: main
Commit: df459be

---

💡 Tips

Supported Commands (Inside Comments)

• Use @traycerai generate to iterate on the previous version of the implementation plan.

Supported Commands (Inside Description)

• Add @traycerai ignore anywhere in the ticket description to prevent this ticket from being processed.
• Add @traycerai branch:<branch-name> anywhere in the ticket description to specify the target branch for the implementation plan.

Community

• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

• Create Plan

Examples

• Example 1
• Example 2

---

🔗 Similar Issues

Related Issues

• lading bump skips version when [package] is out-of-order #52
• Pin Rust toolchain for edition=2024 compatibility rstest-bdd#131
• Align CI toolchain with declared MSRV (Rust 1.85.0) netsuke#119
• Binary location fails in Cargo workspace setups mxd#148

👤 Suggested Assignees

• coderabbitai
• leynos

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!