Reformat Markdown docs with mdformat-all - #132
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
👮 Files not reviewed due to content moderation or server errors (5)
Markdown documentation reformat using mdformat-all across five documentation files. Prose and list items are re-wrapped to the house width standard, and long inline code spans are moved to their own lines. No semantic changes to content, headings, links, ordered-list numbering or Mermaid diagrams. Files affected:
MD013 violations: Four line-length violations introduced by mdtablefix were manually resolved with Total changes: +86 lines / −83 lines WalkthroughThis pull request reformats and rewraps content across five documentation files without introducing code changes or altering functional contracts. REST pagination schemas, observability port abstractions, system design API specifications, execution plan milestones, and user guidance are restructured across multiple lines and adjusted for readability and consistency. ChangesDocumentation reflow and formatting
Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 20✅ Passed checks (20 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Run `make fmt`, which applies mdformat-all (mdtablefix + markdownlint-cli2 --fix) across the documentation tree. The changes are pure formatting: prose and list items are re-wrapped to the house width, and long inline code spans are pulled onto their own lines. No prose meaning, headings, links, ordered-list numbering, or Mermaid diagrams change; several previously broken code-span wraps are corrected. mdtablefix places unbreakable inline code spans (full type signatures and a pytest invocation) on a single line, which overflows markdownlint's 80-column MD013 limit and cannot be auto-fixed. Add four `markdownlint-disable-next-line MD013` guards so `make markdownlint` passes and `make fmt` stays idempotent (mdtablefix preserves the guard lines and leaves the guarded spans untouched on re-run). Gates: `make markdownlint` clean (0 errors); `make nixie` validates all Mermaid diagrams (passes outwith the Chrome sandbox). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6ece7e4 to
0103573
Compare
Summary
Runs
make fmt(which applies mdformat-all =mdtablefix+markdownlint-cli2 --fix) across the documentation tree and commits the result. Twelve Markdown files underdocs/are reformatted.The changes are pure formatting — prose and list items re-wrapped to the house width, and long inline code spans pulled onto their own lines. No prose meaning, headings, links, ordered-list numbering, or Mermaid diagrams change. In a few places the formatter corrects previously broken code-span wrapping (e.g. closing backticks that had drifted to the start of the next line).
Inspection findings
I reviewed every hunk for semantic breakage and new lint violations:
MD013(line-length > 80) violations — the only incorrect output. All share one root cause:mdtablefix --wrapplaces an unbreakable inline code span (a full type signature or apytestinvocation) on its own line, overflowing the 80-column limit, andmarkdownlint --fixcannot auto-fix MD013. These files passed markdownlint cleanly atHEAD, so the reformat introduced them:docs/execplans/2-3-3-generate-guest-bios-from-reference-document-bindings.md:177(86)docs/execplans/4-1-2-finalize-rest-surfaces.md:772(100),:782(87),:859(119)Resolution
Added four
<!-- markdownlint-disable-next-line MD013 -->guards immediately above the offending spans. Verified thatmdtablefixpreserves the guard lines and leaves the guarded spans untouched, somake fmtis idempotent (a second run produces no diff).Gates
make markdownlint— 0 errors.make nixie— all Mermaid diagrams validated (passes outwith the Chrome sandbox; under the sandbox every diagram times out because headless Chrome cannot launch — unrelated to this change, it fails the same way on untouched files).Follow-up worth considering
The
mdtablefix↔MD013conflict will recur for any future doc containing an inline code span longer than ~78 characters. Options: raiseMD013.line_length, teachmdtablefixto break before/after long atomic spans, or keep using per-line guards as here.🤖 Generated with Claude Code