Skip to content

Stabilize compiler and concurrent-probe tests - #67

Draft
lodyai[bot] wants to merge 1 commit into
mainfrom
stabilize-compiler-and-concurrent-probe-tests
Draft

lodyai[bot] wants to merge 1 commit into
mainfrom
stabilize-compiler-and-concurrent-probe-tests

Conversation

@lodyai

@lodyai lodyai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Make the compile-time contract and concurrent write-probe tests reliable on
slower or differently scheduled hosts.

Changes

  • Give the two compiler-spawning erasable-syntax probes the same bounded
    30-second timeout as the other TypeScript contract probes.
  • Treat the two concurrent write-probe entries as order-independent while
    preserving the strict ordering of recovery assessment, review, and
    integration calls around them.

Validation

  • make all

Stack

PR #56 is stacked on this test-stability change.

References

Give compiler-spawning contract probes the same bounded timeout as the
other TypeScript contract tests.

Treat concurrent write-probe entry order as nondeterministic while keeping
the subsequent recovery pipeline ordering strict.
@sourcery-ai

sourcery-ai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR stabilizes tests around compiler behavior and concurrent probe execution by relaxing strict call-order expectations while still validating required probe and pipeline steps, and by giving TypeScript compile-time contract tests longer timeouts.

File-Level Changes

Change Details Files
Relax test assertions on probe call ordering while still enforcing required probe and pipeline steps.
  • Change assertions to sort and compare only the probe-related calls to allow concurrent probe execution.
  • Change assertions to separately validate the non-probe pipeline steps (recover-assess, review, expert-review, integrate) without depending on exact interleaving with probes.
tests/df12-build-odw-recovery.test.mjs
Increase Jest timeouts for compile-time contract tests that invoke the TypeScript compiler.
  • Add explicit 30-second timeout arguments to tests that run the TypeScript compiler with erasableSyntaxOnly enabled and with erasable type-only syntax.
  • Keep existing expectations on compiler output and success/failure unchanged while allowing more time for the process to complete.
tests/modules/compile-time-contract.test.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lodyai lodyai Bot changed the title stabilize compiler and concurrent probe tests Stabilize compiler and concurrent-probe tests Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 972a9d42-036c-4096-a2c7-072b68310547

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant