Align roadmap with the roadmap grammar - #145
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Aligned Also cleaned up the dataset section by:
No roadmap phases, steps, task states, or wording were reordered or changed. WalkthroughDocumentation-only update to docs/roadmap.md: converts the benchmark dataset table from footnote-based citations to inline links, removes the footnote definitions block, adjusts related guidance prose, and fixes minor line-wrapping formatting in the exit-criteria section. ChangesRoadmap Documentation Update
Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 20✅ Passed checks (20 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The unnumbered "Benchmark dataset suite" section (dataset table, provenance notes, and two unnumbered level-3 subsections) trailed the numbered phases, and the mapsplice roadmap grammar rejects unnumbered headings after the first numbered phase. The section also used footnote references, which the grammar rejects anywhere in the document. Relocate the section into the preamble, before the first phase, keeping its headings and wording intact. Convert the ten footnotes to inline links on the dataset names in the table, drop the now-redundant footnote markers from the provenance notes, and remove the footnote definition block. Realign the table columns after the substitution. No phases, steps, or tasks are reordered, renumbered, or reworded.
c503df1 to
e38c1be
Compare
Summary
This branch aligns the roadmap with the mapsplice roadmap grammar. The
trailing
## Benchmark dataset suitesection (dataset table, provenancenotes, and two unnumbered level-3 subsections) sat after the numbered phases,
which the grammar rejects ("unsupported non-roadmap heading inside the roadmap
body"). It also used footnote references (
[^1]–[^10]), which the grammarrejects anywhere in the document. The section moves, headings and wording
intact, into the preamble before the first phase; the footnotes become inline
links on the dataset names in the table; the redundant footnote markers in the
provenance notes are dropped and the footnote definition block removed. No
phases, steps, or tasks are reordered, renumbered, or reworded, and no
checkbox states change.
Review walkthrough
## 0.onwards is otherwise untouched.Validation
mapsplice append docs/roadmap.md <dummy-phase>: exit 0 (grammar-clean)bunx markdownlint-cli2 docs/roadmap.md: 0 errorsNotes
because it trips markdownlint MD036 (emphasis used instead of a heading);
the section is reference material rather than task-like content, so
converting it to a numbered phase was also inappropriate.
they were removed rather than duplicated as a second set of inline links;
every footnote URL survives exactly once, on the dataset name in the table.
## 0., which the grammar's phase rule disallows (phases must be positiveintegers), yet the mechanical checker accepts the document by treating the
zero-numbered phase as preamble. Shifting to 1-based numbering would
renumber every phase, step, task, and cross-reference in the document —
exactly the renumbering churn this exercise forbids — so it is flagged
here for a human decision instead.