-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake support #116
Comments
Hi! I'll think about it. Now it's a modular system, and it needs to be supported in cmake. |
Hello, |
Hi @brano543 Thanks! Merged! You can see previous cmake file (removed 21 Mar) And there it is necessary to maintain the modularity of the system |
And for a Linux we need add |
I don' t know what am i doing wrong, but when i add_subdirectory, and set up includes, even in target_link_library i add myhtml, still i get undefined reference errors.... |
That is, your variant of CMakeLists.txt does not work? |
i will try, but i don't know why i get unreferenced symbols, i am sure i include all of the files and the library is linked correctly. |
I have fixed the cmake build. I didn' t notice i was overriding the variable 3 times, because i didn't put it into single command. #121 |
Merged! |
The problem is it is difficult to tell cmake to exclude that just one port directory, because you have to choose between the OS. If i just include both of them, it won' t compile, because there will be same definitions for the ported functions. |
Great job, i just had to fix one typo in the path for ports. You have accidentally went one directory upwards from current cmake source directory. I have fixed that in #122 and it is building just fine |
Have we solved this problem? |
Hello, I see you have made some changes to the CMakeLists.txt. I will update version of the submodule in my project and let you know if it still works. I have quickly reviewed the changes and it should, but may I ask you for one change though? Could you please rename the arguments |
Hi! |
Ok, after you rename I will test it. |
@brano543 |
Thank you for changing those variables ! It is working fine, thank you for doing such a great job in improving the CmakeLists I made. |
Hello,
would it be possible to write Cmake build file as it is easier to integrate this library as submodule in project.
Thanks in advance.
The text was updated successfully, but these errors were encountered: