Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git rc release version causes assertion error #849

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

yutkat
Copy link
Contributor

@yutkat yutkat commented Aug 6, 2023

My git version is git version 2.42.0-rc0.

This causes the following error because the patch number includes a string.

Error  04:43:36 PM msg_show.lua_error     Error executing luv callback:
...cal/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/async.lua:76: The coroutine failed with this message: ...local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/git.lua:74: assertion failed!
stack traceback:
	[C]: in function 'assert'
	...local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/git.lua:74: in function 'parse_version'
	...local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/git.lua:121: in function '_set_version'
	...local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/git.lua:135: in function 'git_command'
	...local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/git.lua:424: in function 'new'
	...local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/git.lua:753: in function 'new'
	...al/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/attach.lua:288: in function 'fn'
	.../share/nvim/lazy/gitsigns.nvim/lua/gitsigns/debounce.lua:76: in function 'attach_throttled'
	...al/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/attach.lua:423: in function 'attach'
	...ta/.local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns.lua:125: in function 'setup_attach'
	...ta/.local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns.lua:183: in function <...ta/.local/share/nvim/lazy/gitsigns.nvim/lua/gitsigns.lua:159>
stack traceback:
	[C]: in function 'error'
	...cal/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/async.lua:76: in function 'cb'
	...cal/share/nvim/lazy/gitsigns.nvim/lua/gitsigns/async.lua:113: in function 'callback'
	...hare/nvim/lazy/gitsigns.nvim/lua/gitsigns/subprocess.lua:98: in function <...hare/nvim/lazy/gitsigns.nvim/lua/gitsigns/subprocess.lua:86>
	[C]: in function 'system'
	...l/share/nvim/lazy/cmp-tabnine/lua/cmp_tabnine/source.lua:116: in function 'binary'
	...l/share/nvim/lazy/cmp-tabnine/lua/cmp_tabnine/source.lua:267: in function 'on_exit'
	...l/share/nvim/lazy/cmp-tabnine/lua/cmp_tabnine/source.lua:141: in function 'new'
	...cal/share/nvim/lazy/cmp-tabnine/lua/cmp_tabnine/init.lua:20: in function <...cal/share/nvim/lazy/cmp-tabnine/lua/cmp_tabnine/init.lua:19>

According to git's tagging rules, it seems to be OK If you separate them with a hyphen.
https://github.com/git/git/releases/tag/v2.42.0-rc0

@lewis6991 lewis6991 merged commit 3117849 into lewis6991:main Aug 6, 2023
4 checks passed
@lewis6991
Copy link
Owner

Thanks!

@yutkat yutkat deleted the fix/assert branch August 6, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants