-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle id keys in cells #10
Conversation
@krokrob looks like this repo does not have access to the Gemfury credentials |
@brunolajoie thanks for the links. The content seems to suggest that the goal of the Since the On the contrary, if the goal is to allow an app to reference a cell within a notebook session, I struggle to understand how persisting the data on disk helps... My best guess at the moment is that the specification is ongoing or not yet supported by all the tools of the ecosystem. Anyways I suppose we can get rid of these changing values until we identify a pain point (if any ever emerges), in which case we will be able to quickly revert to the previous nbcleanmeta package behavior. WDYT ? |
Let's do that, but before merging, can you just check that
works well with/without ids? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @gmanchon I just have 1 question before merging
@krokrob @brunolajoie as a wrap-up, jupyter notebook, lab and vscode seem to work pretty well without the ids the ids appear with at the moment I was not able to determine precisely what actions cause the ids to reset other than it frequently is the case when working on the lectures |
I had not worked on a notebook for a long time and it felt awful to deal with the
id
sWe have discussed this before and I am not aware that a use case for these ever changing keys has appeared ?
So it would feel safe and quite practical to remove them, WDYT ?
BEFORE
AFTER