Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flake8 linter and AutoPEP8 formatter #77

Merged
merged 2 commits into from
Dec 31, 2020

Conversation

krokrob
Copy link
Member

@krokrob krokrob commented Dec 31, 2020

this fixes lewagon/data-setup#23 @ssaunier please review

@ssaunier
Copy link
Member

ssaunier commented Dec 31, 2020

@krokrob
Copy link
Member Author

krokrob commented Dec 31, 2020

We don't use flake8 for syntax testing atm but it is a good linter for students inside their code ediitor. We will change pylint for flake8` in Q2 I think.

@krokrob
Copy link
Member Author

krokrob commented Dec 31, 2020

I forgot to mention you in lewagon/data-setup#42

@ssaunier
Copy link
Member

The risk of doing 50% of that change is that flake8 in Sublime Text will say something while the pylint through make will say another, don't you think it'll be even more confusing for students?

@krokrob
Copy link
Member Author

krokrob commented Dec 31, 2020

pylint is much more "lazy" than flake8, as it considers devs know how to use code formatter like black or autoPEP8. Our students still need a linter as they are still programming learners. There won't be contradictory syntax error between the 2 frameworks.

@ssaunier ssaunier merged commit aff9529 into master Dec 31, 2020
@ssaunier ssaunier deleted the python-linter-code-formatter branch December 31, 2020 15:29
thmsmrl added a commit to thmsmrl/dotfiles that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "pylint" for "SublimeLinter" for students in setup day 0
2 participants